Baunsgaard commented on PR #2181: URL: https://github.com/apache/systemds/pull/2181#issuecomment-2596052055
> What irritates me a bit is that the rexpand kernels are implemented in `LibMatrixReorg`, which you not even touch. If this code is for the weighted versions of rexpand, please move it there which would also prevent creating too many Lib* classes which were meant for types of operations with many kernels, not individual operations. okay will do, I just had a tendency lately to make Lib files since it made it 'cleaner' in my mind for containing parallel and non parallel calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
