aarnaty commented on code in PR #2190:
URL: https://github.com/apache/systemds/pull/2190#discussion_r1929618243
##########
src/main/java/org/apache/sysds/hops/codegen/cplan/CNodeBinary.java:
##########
@@ -270,26 +271,26 @@ public String toString() {
case VECT_CBIND: return "b(cbind)";
case VECT_BIASADD: return "b(vbias+)";
case VECT_BIASMULT: return "b(vbias*)";
- case MULT: return "b(*)";
- case DIV: return "b(/)";
- case PLUS: return "b(+)";
- case MINUS: return "b(-)";
- case POW: return "b(^)";
- case MODULUS: return "b(%%)";
- case INTDIV: return "b(%/%)";
- case LESS: return "b(<)";
- case LESSEQUAL: return "b(<=)";
- case GREATER: return "b(>)";
- case GREATEREQUAL: return "b(>=)";
- case EQUAL: return "b(==)";
- case NOTEQUAL: return "b(!=)";
+ case MULT: return "b(" +
Opcodes.MULT.getName() + ")";
+ case DIV: return "b(" +
Opcodes.DIV.getName() + ")";
+ case PLUS: return "b(" +
Opcodes.PLUS.getName() + ")";
+ case MINUS: return "b(" +
Opcodes.MINUS.getName() + ")";
+ case POW: return "b(" +
Opcodes.POW.getName() + ")";
+ case MODULUS: return "b(" +
Opcodes.MODULUS.getName() + ")";
+ case INTDIV: return "b(" +
Opcodes.INTDIV.getName() + ")";
+ case LESS: return "b(" +
Opcodes.LESS.getName() + ")";
+ case LESSEQUAL: return "b(" +
Opcodes.LESSEQUAL.getName() + ")";
+ case GREATER: return "b(" +
Opcodes.GREATER.getName() + ")";
+ case GREATEREQUAL: return "b(" +
Opcodes.GREATEREQUAL.getName() + ")";
+ case EQUAL: return "b(" +
Opcodes.EQUAL.getName() + ")";
+ case NOTEQUAL: return "b(" +
Opcodes.NOTEQUAL.getName() + ")";
case OR: return "b(|)";
case AND: return "b(&)";
Review Comment:
There were no opcodes for "|" or "&" in the CPInstructionParser file. The
ones that are covered are "||" and "&&".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
