Baunsgaard commented on code in PR #2194:
URL: https://github.com/apache/systemds/pull/2194#discussion_r1933712684
##########
src/main/java/org/apache/sysds/runtime/matrix/data/MatrixBlock.java:
##########
@@ -1730,6 +1730,9 @@ public void putInto(MatrixBlock target, int rowOffset,
int colOffset, boolean sp
* (the invoker is responsible to recompute nnz after
all copies are done)
*/
public void copy(int rl, int ru, int cl, int cu, MatrixBlock src,
boolean awareDestNZ ) {
+ if (src instanceof CompressedMatrixBlock){
+ src = ((CompressedMatrixBlock) src).decompress();
Review Comment:
add a string to the decompress command to indicate what is causing the
decompression.
##########
src/test/java/org/apache/sysds/test/functions/compress/workload/WorkloadAlgorithmTest.java:
##########
@@ -154,19 +172,21 @@ private void runWorkloadAnalysisTest(String testname,
ExecMode mode, int compres
String HOME = SCRIPT_DIR + TEST_DIR;
fullDMLScriptName = HOME + testname + ".dml";
- programArgs = new String[] {"-stats", "20", "-args",
input("X"), input("y"), output("B")};
+ programArgs = new String[] {"-stats", "20", "-args",
input("X"), input("y"), output("B"),
+ String.valueOf(maxIter)};
writeInputMatrixWithMTD("X", X, false);
writeInputMatrixWithMTD("y", y, false);
- String ret = runTest(null).toString();
+ ByteArrayOutputStream out = runTest(null);
+ String ret = out != null ? out.toString() : "";
LOG.debug(ret);
// check various additional expectations
long actualCompressionCount = (mode == ExecMode.HYBRID
|| mode == ExecMode.SINGLE_NODE) ? Statistics
.getCPHeavyHitterCount("compress") :
Statistics.getCPHeavyHitterCount("sp_compress");
-
- Assert.assertEquals("Assert that the compression counts
expeted matches actual: " + compressionCount + " vs "
+ System.out.println(actualCompressionCount);
Review Comment:
remove System out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
