e-strauss opened a new pull request, #2228: URL: https://github.com/apache/systemds/pull/2228
This PR consolidates the parameters of the builtin DML scripts and introduces a formatting sheme for the DML builtin parameters. Additionally, the changes were also applied to the Python API using the auto generator script, where I added a small fix, because some builtins were not parsed correctly. The changes also resulted in a couple changes in the test script for the builtin scripts. For the discovery of the usages of the changed builtins, I had to manually "grep" the ./src/test/scripts folder, so that I dont break any tests, but also the ./script folder to catch the usages in tutorials, perftest, etc. I hope, I've catched everything there, but I can not guaranty it, since the github test just run on test script folder. I applied the following formatting convention: - camelCase, no "_" - matrix / vector arguments must be capitalized - for scalars, the first character must be lower case allowed: X, Xtest, ScaleFactor, tol, maxIter not allowed: X_test, max_iter Furtheremore, I used the following python script / notebook for the discovery of all unique parameter names: https://gist.github.com/e-strauss/ccec59f504ed3882a2141d859ff681ec In the following, I want to give a quick overview over the consolidations, that I applied. In total, I found 62 matches for consolidation and reduced the total number of unique parameters to 340, which was previously at 402. I changed the spelling of the following 76 parameters names: https://gist.github.com/e-strauss/3a5f27160178024c079ed37072c54cfa Through either consolidation or applying the naming convention, I removed the following 138 parameter names: https://gist.github.com/e-strauss/3a5f27160178024c079ed37072c54cfa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
