mboehm7 commented on PR #2200: URL: https://github.com/apache/systemds/pull/2200#issuecomment-2869851413
LGTM - sorry for the delay and thanks for the contribution @saminbassiri. Overall, this patch already looks pretty good. During the merge, I only fixed the formatting of java tests (tabs over spaces in Java), fixed the frame-typing of the builtin function, and left a few TODOs to later vectorize some of the loops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org