mboehm7 commented on PR #2288:
URL: https://github.com/apache/systemds/pull/2288#issuecomment-3048197296

   LGTM - thanks for the patch @philipportner. I'll merge it in as is, but the 
padding might be done more efficiently directly during the creation of the 
permutation matrix as table() supports padding (I'll think about it, but quick 
tries were unsuccessful) and note that builtin functions can be called without 
imports (here raGroupby instead of m_raGroupby). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to