Baunsgaard commented on code in PR #2274:
URL: https://github.com/apache/systemds/pull/2274#discussion_r2192107569
##########
docker/sysds.Dockerfile:
##########
@@ -43,22 +41,25 @@ ENV SYSTEMDS_ROOT=/usr/src/systemds
ENV PATH=$SYSTEMDS_ROOT/bin:$PATH
ENV SYSDS_QUIET=1
-# Download Java and Mvn
+# Download Mvn and JDK
RUN mkdir -p /usr/lib/jvm \
&& wget -qO- \
-
https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.15%2B6/OpenJDK17U-jdk_x64_linux_hotspot_17.0.15_6.tar.gz
| tar xzf - \
- && mv jdk-17.0.15+6 /usr/lib/jvm/jdk-17.0.15+6 \
+
https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.15%2B6/OpenJDK17U-jdk_x64_alpine-linux_hotspot_17.0.15_6.tar.gz
| tar xzf - \
+ && mv jdk-17.0.15+6 $JAVA_HOME \
&& wget -qO- \
http://archive.apache.org/dist/maven/maven-3/$MAVEN_VERSION/binaries/apache-maven-$MAVEN_VERSION-bin.tar.gz
| tar xzf - \
&& mv apache-maven-$MAVEN_VERSION /usr/lib/mvn
# Build the system
-RUN git clone --depth 1 https://github.com/apache/systemds.git systemds && \
+RUN git clone -b SYSTEMDS-3877 --depth 1
https://github.com/alexanderschmi/systemds.git systemds && \
Review Comment:
when cleaning up the PR, we need to change this line.
##########
docker/mountFolder/main.dml:
##########
@@ -19,4 +19,15 @@
#
#-------------------------------------------------------------
-print("Hello, World!");
\ No newline at end of file
+# kmeans_test.dml
+# Simple KMeans clustering test
+
+# Arguments
+X = read("test.bin")
+
+# Run KMeans
+[centroids, assignments] = kmeans(X=X, k=2, max_iter=100, eps=0.01)
+
+print(centroids)
+print(assignments)
+write(centroids, "centroids.bin")
Review Comment:
lets add a newline in the end of this file.
##########
docker/mountFolder/.gitignore:
##########
Review Comment:
remove this file, and instead edit the main .gitignore file in the root of
the project.
##########
docker/mountFolder/main.dml:
##########
@@ -19,4 +19,15 @@
#
#-------------------------------------------------------------
-print("Hello, World!");
\ No newline at end of file
+# kmeans_test.dml
+# Simple KMeans clustering test
+
+# Arguments
+X = read("test.bin")
Review Comment:
This will only work if there is a test.bin file. Please change back to the
in place construction of the matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
