mboehm7 commented on PR #2305: URL: https://github.com/apache/systemds/pull/2305#issuecomment-3172469843
LGTM - thanks for the nice addition to the OOC backend. During the merge, I fixed the formatting (tabs over spaces in Java code), extended the tests slightly (with what you already planned), used the slice function for consistency, removed the task.get() which would block until the entire input is processed, and optimized the case of a single column block (which does not need any aggregation and allows streaming). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
