mboehm7 commented on PR #2310:
URL: https://github.com/apache/systemds/pull/2310#issuecomment-3211168464

   LGTM - thanks @jessicapriebe for this patch and improvement. During the 
merge, I only slightly moved the count maintenance around such that we only 
replace these counts (which is a hashmap update) if we do not anyway output the 
block and then remove the count. As a future step, we should think about some 
util methods / classes for encapsulating the count maintenance and early 
emission of blocks.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to