j143 commented on code in PR #2343:
URL: https://github.com/apache/systemds/pull/2343#discussion_r2476361252
##########
src/main/java/org/apache/sysds/runtime/instructions/ooc/ResettableStream.java:
##########
@@ -19,31 +19,48 @@
package org.apache.sysds.runtime.instructions.ooc;
+import org.apache.sysds.runtime.controlprogram.caching.OOCEvictionManager;
import org.apache.sysds.runtime.controlprogram.parfor.LocalTaskQueue;
import org.apache.sysds.runtime.instructions.spark.data.IndexedMatrixValue;
+import java.io.IOException;
import java.util.ArrayList;
+import java.util.UUID;
Review Comment:
done
##########
src/main/java/org/apache/sysds/runtime/instructions/ooc/ResettableStream.java:
##########
@@ -19,31 +19,48 @@
package org.apache.sysds.runtime.instructions.ooc;
+import org.apache.sysds.runtime.controlprogram.caching.OOCEvictionManager;
import org.apache.sysds.runtime.controlprogram.parfor.LocalTaskQueue;
import org.apache.sysds.runtime.instructions.spark.data.IndexedMatrixValue;
+import java.io.IOException;
import java.util.ArrayList;
+import java.util.UUID;
/**
* A wrapper around LocalTaskQueue to consume the source stream and reset to
* consume again for other operators.
+ * <p>
+ * Uses OOCEvictionManager for out-of-core caching.
*
*/
public class ResettableStream extends LocalTaskQueue<IndexedMatrixValue> {
// original live stream
private final LocalTaskQueue<IndexedMatrixValue> _source;
- // in-memory cache to store stream for re-play
- private final ArrayList<IndexedMatrixValue> _cache;
+ // stream identifier
+ private final String _streamId;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
