mboehm7 commented on PR #2368: URL: https://github.com/apache/systemds/pull/2368#issuecomment-3695929077
LGTM - sorry for the delay, and thanks for the various improvements @janniklinde. These changes are great progress towards full algorithm support. During the merge, I fixed minor issues related to unnecessary imports, missing synchronization of overwritten methods, and duplicated but commented code. For the PCA test, it would be good to add the result comparison with a future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
