phaniarnab commented on PR #2392: URL: https://github.com/apache/systemds/pull/2392#issuecomment-3698864441
> > This is indeed great @janniklinde. It will make it easier to merge smaller patches from external contributors. Wondering is there a way to check the codestyle against the dev/CodeStyle_eclipse.xml file? There are many other checks available in that file, such as line length. > > Should be possible @phaniarnab, I can look into that. However, I guess that we will have to suppress a lot of existing java classes because these checks will be quite strict. In general, I agree that it should be enforced to run the code formatter before merging to keep the styles consistent, I am just not sure how to cleanly transition to that state. Thanks. I do not have a clear answer. I think your approach of incrementally adding new rules is likely the right approach. Our goal is to enforce consistent code style for developers, without requiring them to modify or reformat existing code written by others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
