Baunsgaard commented on PR #2379: URL: https://github.com/apache/systemds/pull/2379#issuecomment-3760286275
> @Baunsgaard @mboehm7 https://github.com/apache/systemds/blob/8de93a1f996348c260d48c1c29340d5a88005e6f/src/main/python/systemds/context/systemds_context.py#L772C4-L772C20 > > the naming "from_numpy" is misleading since we support now scipy compressed matrices as well shall we rename it to something like "from_py_matrix", "from_array_like"? > > We could also use something like "from_pydata" which merges the two separate methods from_numpy and from_pandas to single method, internally we could route to the corresponding handler based on the input instance type. This sounds good to me, unifying the API would be fine. However, 1. when doing it do not break backwards compatibility. 2. when calling the old methods report a deprecated message to the user via the logging framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
