Baunsgaard commented on code in PR #2397:
URL: https://github.com/apache/systemds/pull/2397#discussion_r2812322204
##########
src/main/java/org/apache/sysds/runtime/transform/encode/EncoderFactory.java:
##########
@@ -276,19 +278,21 @@ public static ColumnEncoder createInstance(int type) {
case Bin:
return new ColumnEncoderBin();
case Dummycode:
- return new ColumnEncoderDummycode();
- case FeatureHash:
- return new ColumnEncoderFeatureHash();
- case PassThrough:
- return new ColumnEncoderPassThrough();
- case Recode:
- return new ColumnEncoderRecode();
- case WordEmbedding:
- return new ColumnEncoderWordEmbedding();
- case BagOfWords:
- return new ColumnEncoderBagOfWords();
- default:
- throw new DMLRuntimeException("Unsupported
encoder type: " + etype);
+ return new ColumnEncoderDummycode();
+ case FeatureHash:
+ return new ColumnEncoderFeatureHash();
+ case PassThrough:
+ return new ColumnEncoderPassThrough();
+ case Recode:
+ return new ColumnEncoderRecode();
+ case WordEmbedding:
+ return new ColumnEncoderWordEmbedding();
+ case BagOfWords:
+ return new ColumnEncoderBagOfWords();
+ case UDF:
+ return new ColumnEncoderUDF();
+ default:
+ throw new DMLRuntimeException("Unsupported encoder
type: " + etype);
Review Comment:
Seems like the indentation is somehow changed. Should be fixed to highlight
the new case you added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
