Baunsgaard commented on code in PR #2432:
URL: https://github.com/apache/systemds/pull/2432#discussion_r2816044645
##########
src/test/java/org/apache/sysds/test/functions/mlcontext/MLContextTestBase.java:
##########
@@ -76,13 +72,6 @@ public void setUp() {
addTestConfiguration(dir, name);
getAndLoadTestConfiguration(name);
-
- //run all mlcontext tests in loglevel trace to improve test
coverage
Review Comment:
It is a bit annoying but people do this if we are not carefull.
In essence, many places use :
```java
if(LOG.isDebug()) {
// some code
}
```
This means code coverage will be low, unless we explicity enable the
logging.
We can circumvent it by having explicit logging tests, instead of just fully
enabling logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
