e-strauss commented on code in PR #2435:
URL: https://github.com/apache/systemds/pull/2435#discussion_r2822059314
##########
src/main/java/org/apache/sysds/hops/cost/CostEstimator.java:
##########
@@ -155,18 +155,16 @@ else if( pb instanceof BasicProgramBlock )
//awareness of recursive
functions, missing program
if( !memoFunc.contains(fkey) &&
pb.getProgram()!=null )
{
- if(LOG.isDebugEnabled())
-
LOG.debug("Begin Function "+fkey);
-
+ LOG.debug("Begin
Function " + fkey);
Review Comment:
I see your point, but isnt it in practice in micro-level noise for these
simple concats? i think we might over-engineer here
Why are we sticking to apache commons logging? with the newer SLF4J we would
could do stuff like this:
```java
LOG.debug("Begin Function {}", fkey);
```
also SLF4J might already be used inside apachae commons logging, since it's
already in the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
