janniklinde commented on code in PR #2437: URL: https://github.com/apache/systemds/pull/2437#discussion_r2884768622
########## src/test/java/org/apache/sysds/test/functions/ooc/CBindTest.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sysds.test.functions.ooc; + +import org.apache.sysds.common.Opcodes; +import org.apache.sysds.common.Types; +import org.apache.sysds.runtime.instructions.Instruction; +import org.apache.sysds.runtime.io.MatrixWriter; +import org.apache.sysds.runtime.io.MatrixWriterFactory; +import org.apache.sysds.runtime.matrix.data.MatrixBlock; +import org.apache.sysds.runtime.meta.MatrixCharacteristics; +import org.apache.sysds.runtime.util.DataConverter; +import org.apache.sysds.runtime.util.HDFSTool; +import org.apache.sysds.test.AutomatedTestBase; +import org.apache.sysds.test.TestConfiguration; +import org.apache.sysds.test.TestUtils; +import org.junit.Assert; +import org.junit.Test; + +public class CBindTest extends AutomatedTestBase { + + private static final String TEST_NAME = "CBindTest"; + private static final String TEST_DIR = "functions/ooc/"; + private static final String TEST_CLASS_DIR = TEST_DIR + CBindTest.class.getSimpleName() + "/"; + + private final static double eps = 1e-8; + private static final String INPUT_NAME_1 = "A"; + private static final String INPUT_NAME_2 = "B"; + private static final String OUTPUT_NAME = "res"; + + @Override + public void setUp() { + TestUtils.clearAssertionInformation(); + addTestConfiguration(TEST_NAME, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME)); + } + + @Test + public void testCBindAppendBlock() { runCBindTest(1000, 1000, 1000, 1000);} + + @Test + public void testCBindAppendBlockTwoLeftBlocks() {runCBindTest(1000, 2000, 1000, 1000);} + + @Test + public void testCBindPartialFillSingleRightBlock() { runCBindTest(1000, 1100, 1000, 100);} + + @Test + public void testCBindTotalFillSingleBlockEachSide() { runCBindTest(1000, 500, 1000, 500);} + + @Test + public void testCBindTotalFillTwoRightBlocks() { runCBindTest(1000, 3500, 1000, 1500);} + + @Test + public void testCBindPartialFillMultipleBlocksEachSide() { runCBindTest(1000, 3100, 1000, 3200);} + + @Test + public void testCBindTotalFillMultipleBlocksEachSide() { runCBindTest(1000, 3500, 1000, 3500);} + + @Test + public void testCBindOverflowSingleRightBlock() { runCBindTest(1000, 1600, 1000, 600);} + + @Test + public void testCBindOverflowMultipleRightBlocks() { runCBindTest(1000, 1600, 1000, 2600);} + + @Test + public void testCBindOverflowTotalFilledSingleRightBlock() {runCBindTest(1000, 1100, 1000, 1000);} + + @Test + public void testCBindOverflowTotalFilledTwoRightBlocks() {runCBindTest(1000, 1100, 1000, 2000);} + + @Test + public void testCBindMultipleRows() { runCBindTest(2500, 1500, 2500, 1500);} + + @Test + public void testCBind() {runCBindTest(2300, 1655, 2300, 2542);} Review Comment: These edge cases are indeed good to have. Currently, OOC largely misses these tests for other operators as well (I will work on it to increase coverage). As I am aware of some bugs for different block sizes, it is good to have that additional parameter but not use different block sizes for now (like you did in the last commit). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
