janniklinde commented on PR #2460:
URL: https://github.com/apache/systemds/pull/2460#issuecomment-4305464648
Thanks for the additional rewrite implementations and corresponding tests
@smelihportakal. In your tests, could you validate that your rewrites are
actually applied as an additional assert? You could use the heavy hitters
similar to `RewriteSimplifyNegatedSubtractionTest` (e.g.,
`Assert.assertEquals(1, Statistics.getCPHeavyHitterCount("-"));`).
For colsum/rowsum pushdown, you could test an alternative expression such as
`2*colSums(3*X)`, where after your rewrite there should only be a single
multiply present as a heavy hitter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
