Baunsgaard opened a new pull request, #2480:
URL: https://github.com/apache/systemds/pull/2480
Tightens the hot path that converts FrameBlocks of arbitrary schema into
MatrixBlocks, with a defensive fallback for malformed cells.
- DoubleParser.parseFloatingPointLiteral: replace the >= 'I' / >= 'a'
character guards with a single 0-9 range check on the last char. The previous
guards over-matched and pushed too many strings into the slow
Double.parseDouble path
- DoubleArray.parseDouble: stop wrapping the parse failure as a
DMLRuntimeException so callers can distinguish format errors
- MatrixBlockFromFrame:
- turn the interface into a class with a private constructor so Jacoco
can measure it cleanly
- on NumberFormatException / DMLRuntimeException during a bulk block
convert, log once and fall back to convertSafeCast which writes NaN per
offending cell instead of failing the whole job
- add convertSafeCast / convertBlockSafeCast helpers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
