janniklinde commented on code in PR #2489:
URL: https://github.com/apache/systemds/pull/2489#discussion_r3413093784
##########
src/main/java/org/apache/sysds/runtime/instructions/ooc/OOCInstruction.java:
##########
@@ -1196,7 +1196,7 @@ protected <T> CompletableFuture<Void>
submitOOCTasks(OOCStream<T> queue, Consume
}
protected CompletableFuture<Void> submitOOCTask(Runnable r,
StreamContext ctx) {
- ExecutorService pool = CommonThreadPool.get();
+ ExecutorService pool = CommonThreadPool.getDynamicPool();
Review Comment:
This should make a difference because `submitOOCTask` may be used for
blocking work (e.g. `dequeue()`). If we now use a fixed sized thread pool
(which especially causes problems in environments with fewer enabled CPUs thus
smaller number of workers on the default thread pool), this may block scheduled
tasks from making progress that are needed for those workers to unblock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
