Baunsgaard commented on code in PR #2528:
URL: https://github.com/apache/systemds/pull/2528#discussion_r3529198911


##########
src/test/resources/datasets/parquet/all.parquet:
##########


Review Comment:
   
   If you want to make a PR that makes the Delta read and write faster as well 
that is great!
   
   About the results, these are just the delta read and write. What would be 
interesting is comparing your raw parquet read and write functions (the PR you 
are making) and comparing it to the delta read and write, and as an extra bonus 
compare it to our internal binary format.
   
   I know you have the results above, I just need you to combine them in a 
single table.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to