Biranavan-Parameswaran commented on PR #2496: URL: https://github.com/apache/systemds/pull/2496#issuecomment-5110160490
> Thank you very much for this contribution. :) The code looks very good. I only added some minor comments regarding variable naming. A general aspect to consider: Do you think it is possible to make the `FederatedChunkCodecTest` even faster in terms of runtime needed for the test while testing the same functionality? All the best, David Thanks @ywcb00 , all comments resolved! :) Regarding `FederatedChunkCodecTest`: I tried a few variants. The actual work is only ~50ms. I have a slightly faster version, but it costs a lot of readability in the polling helpers. Happy to commit it if you'd prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
