Isso-W commented on code in PR #2542:
URL: https://github.com/apache/systemds/pull/2542#discussion_r3694688256
##########
src/test/java/org/apache/sysds/test/functions/unique/UniqueBase.java:
##########
@@ -40,8 +41,39 @@ public void setUp() {
protected void uniqueTest(double[][] inputMatrix, double[][]
expectedMatrix,
Types.ExecType
instType, double epsilon) {
+ uniqueTest(inputMatrix, expectedMatrix, instType, epsilon, -1,
false);
+ }
+
+ /**
+ * Runs the unique script and compares the result row by row, in order.
Use this where the expected output is
+ * unambiguous, i.e. where every row or column of the result holds a
single value and the iteration order of the
+ * internal hash sets cannot affect the outcome.
+ */
+ protected void uniqueTestOrdered(double[][] inputMatrix, double[][]
expectedMatrix, Types.ExecType instType,
Review Comment:
It was unnecessary, Removed in next push
##########
src/test/java/org/apache/sysds/test/functions/unique/UniqueBase.java:
##########
@@ -52,9 +84,13 @@ protected void uniqueTest(double[][] inputMatrix, double[][]
expectedMatrix,
runTest(true, false, null, -1);
writeExpectedMatrix("A", expectedMatrix);
- compareResultsRowsOutOfOrder(epsilon);
+ if(orderedComparison)
Review Comment:
Also removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
