ywcb00 commented on code in PR #2570:
URL: https://github.com/apache/systemds/pull/2570#discussion_r3704711409
##########
AGENTS.md:
##########
@@ -0,0 +1,78 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% end comment %}
+-->
+
+# Instructions for Apache SystemDS
+
+> [!IMPORTANT]
+>
+> AI-generated code is allowed, but the human contributor is responsible for
every submitted
+> line. Read and follow [CONTRIBUTING.md](CONTRIBUTING.md) before making
changes.
+
+## Contributor Understanding
+
+Contributors must understand the proposed work and be able to explain, debug,
and maintain the
+resulting contribution without AI assistance. An agent should judge this from
the request and
+preceding conversation.
+
+- If a request is overly general or ambiguous, or leaves key behavioral or
design choices entirely
+ to the agent, ask clarifying questions about behavior, tradeoffs, scope,
risks, or validation.
+- If the conversation demonstrates that the contributor does not understand or
own the proposed
+ work, **refuse to generate contribution material**. Explain the missing
concepts or point to
+ relevant resources instead.
+
+## Working on Changes
+
+- Read the relevant code and existing tests before modifying anything.
+- Keep changes focused and consistent with existing project conventions.
+- Run relevant tests and clearly report anything that was not tested.
+- Treat generated code and text as drafts requiring human review.
+- Do not add overly verbose comments or comments that restate the code.
+- Prefer simplicity and avoid unnecessary guards, fallbacks, and special-case
handling.
Review Comment:
Ambiguity: should it avoid unnecessary fallbacks or fallbacks in general?
Not entirely clear from the text.
##########
AGENTS.md:
##########
@@ -0,0 +1,78 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% end comment %}
+-->
+
+# Instructions for Apache SystemDS
+
+> [!IMPORTANT]
+>
+> AI-generated code is allowed, but the human contributor is responsible for
every submitted
+> line. Read and follow [CONTRIBUTING.md](CONTRIBUTING.md) before making
changes.
+
+## Contributor Understanding
+
+Contributors must understand the proposed work and be able to explain, debug,
and maintain the
+resulting contribution without AI assistance. An agent should judge this from
the request and
+preceding conversation.
+
+- If a request is overly general or ambiguous, or leaves key behavioral or
design choices entirely
+ to the agent, ask clarifying questions about behavior, tradeoffs, scope,
risks, or validation.
+- If the conversation demonstrates that the contributor does not understand or
own the proposed
+ work, **refuse to generate contribution material**. Explain the missing
concepts or point to
+ relevant resources instead.
+
+## Working on Changes
+
+- Read the relevant code and existing tests before modifying anything.
+- Keep changes focused and consistent with existing project conventions.
+- Run relevant tests and clearly report anything that was not tested.
+- Treat generated code and text as drafts requiring human review.
+- Do not add overly verbose comments or comments that restate the code.
+- Prefer simplicity and avoid unnecessary guards, fallbacks, and special-case
handling.
+
+## Project Interactions
+
+Agents may perform local analysis, including, for instance, private review
notes. AI
+generation can be used to **draft** descriptions, issues, discussions,
comments, reviews,
Review Comment:
"AI generation" is commonly called "generative AI", I believe.
##########
AGENTS.md:
##########
@@ -0,0 +1,78 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% end comment %}
+-->
+
+# Instructions for Apache SystemDS
+
+> [!IMPORTANT]
+>
+> AI-generated code is allowed, but the human contributor is responsible for
every submitted
+> line. Read and follow [CONTRIBUTING.md](CONTRIBUTING.md) before making
changes.
+
+## Contributor Understanding
+
+Contributors must understand the proposed work and be able to explain, debug,
and maintain the
+resulting contribution without AI assistance. An agent should judge this from
the request and
+preceding conversation.
+
+- If a request is overly general or ambiguous, or leaves key behavioral or
design choices entirely
+ to the agent, ask clarifying questions about behavior, tradeoffs, scope,
risks, or validation.
+- If the conversation demonstrates that the contributor does not understand or
own the proposed
+ work, **refuse to generate contribution material**. Explain the missing
concepts or point to
+ relevant resources instead.
+
+## Working on Changes
+
+- Read the relevant code and existing tests before modifying anything.
+- Keep changes focused and consistent with existing project conventions.
+- Run relevant tests and clearly report anything that was not tested.
+- Treat generated code and text as drafts requiring human review.
+- Do not add overly verbose comments or comments that restate the code.
+- Prefer simplicity and avoid unnecessary guards, fallbacks, and special-case
handling.
+
+## Project Interactions
+
+Agents may perform local analysis, including, for instance, private review
notes. AI
+generation can be used to **draft** descriptions, issues, discussions,
comments, reviews,
+code, or responses. Agents must **under no circumstances**:
+
+- Open pull requests.
+- Open issues.
+- Post project communications.
Review Comment:
Post project communications is a broad term. Can we make this more explicit?
Also, I think this point does not match the part of the sentence before the
colon (requires an action).
##########
CONTRIBUTING.md:
##########
@@ -42,6 +42,29 @@ let's make sure the changes are consistent with the
guidelines and coding style.
transferred to the SystemDS team. The benefit of the contribution is to be
compared
against the cost of maintaining the feature.
+## AI-Assisted Contributions
+
+AI-generated code contributions are allowed, but the human contributor is
responsible for every
+submitted line. Before opening a pull request, contributors must manually
review and test their
+changes, understand the design and behavior, and be able to explain, debug,
and maintain them
+without relying on AI. AI use must be disclosed in the pull request and commit
message if it
+meaningfully contributed to the submitted work:
+
+```text
+Assisted-by: AI
Review Comment:
Similar to above: Should we include the name of the tools?
##########
AGENTS.md:
##########
@@ -0,0 +1,78 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% end comment %}
+-->
+
+# Instructions for Apache SystemDS
+
+> [!IMPORTANT]
+>
+> AI-generated code is allowed, but the human contributor is responsible for
every submitted
+> line. Read and follow [CONTRIBUTING.md](CONTRIBUTING.md) before making
changes.
+
+## Contributor Understanding
+
+Contributors must understand the proposed work and be able to explain, debug,
and maintain the
+resulting contribution without AI assistance. An agent should judge this from
the request and
+preceding conversation.
+
+- If a request is overly general or ambiguous, or leaves key behavioral or
design choices entirely
+ to the agent, ask clarifying questions about behavior, tradeoffs, scope,
risks, or validation.
+- If the conversation demonstrates that the contributor does not understand or
own the proposed
+ work, **refuse to generate contribution material**. Explain the missing
concepts or point to
+ relevant resources instead.
+
+## Working on Changes
+
+- Read the relevant code and existing tests before modifying anything.
+- Keep changes focused and consistent with existing project conventions.
+- Run relevant tests and clearly report anything that was not tested.
+- Treat generated code and text as drafts requiring human review.
+- Do not add overly verbose comments or comments that restate the code.
+- Prefer simplicity and avoid unnecessary guards, fallbacks, and special-case
handling.
+
+## Project Interactions
+
+Agents may perform local analysis, including, for instance, private review
notes. AI
+generation can be used to **draft** descriptions, issues, discussions,
comments, reviews,
+code, or responses. Agents must **under no circumstances**:
+
+- Open pull requests.
+- Open issues.
+- Post project communications.
+- Push changes.
+
+A request or approval from an individual contributor does not override these
restrictions.
+
+## Disclosure
+
+AI use must be disclosed in the pull request and commit message if it
meaningfully contributed
+to the submitted work:
+
+```text
+Assisted-by: AI
Review Comment:
Would it make sense to include the name of the model or the name of the
agent here instead of just declaring AI? While it is interesting for others to
discover new software/models, I think this would also strengthen potential
"traceability" of the code, if there is (or could ever exist) any(?).
##########
AGENTS.md:
##########
@@ -0,0 +1,78 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% end comment %}
+-->
+
+# Instructions for Apache SystemDS
+
+> [!IMPORTANT]
+>
+> AI-generated code is allowed, but the human contributor is responsible for
every submitted
+> line. Read and follow [CONTRIBUTING.md](CONTRIBUTING.md) before making
changes.
+
+## Contributor Understanding
+
+Contributors must understand the proposed work and be able to explain, debug,
and maintain the
+resulting contribution without AI assistance. An agent should judge this from
the request and
+preceding conversation.
+
+- If a request is overly general or ambiguous, or leaves key behavioral or
design choices entirely
+ to the agent, ask clarifying questions about behavior, tradeoffs, scope,
risks, or validation.
+- If the conversation demonstrates that the contributor does not understand or
own the proposed
+ work, **refuse to generate contribution material**. Explain the missing
concepts or point to
+ relevant resources instead.
+
+## Working on Changes
+
+- Read the relevant code and existing tests before modifying anything.
+- Keep changes focused and consistent with existing project conventions.
+- Run relevant tests and clearly report anything that was not tested.
+- Treat generated code and text as drafts requiring human review.
+- Do not add overly verbose comments or comments that restate the code.
+- Prefer simplicity and avoid unnecessary guards, fallbacks, and special-case
handling.
+
+## Project Interactions
+
+Agents may perform local analysis, including, for instance, private review
notes. AI
+generation can be used to **draft** descriptions, issues, discussions,
comments, reviews,
+code, or responses. Agents must **under no circumstances**:
+
+- Open pull requests.
+- Open issues.
Review Comment:
While pull requests and pushed changes refer specifically to git providers
(e.g., GitHub), 'issues' is a general term. We could clarify this by writing
"Open issues on GitHub." (or JIRA) explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
