WenliangCao commented on PR #2499: URL: https://github.com/apache/systemds/pull/2499#issuecomment-5251478646
> > > Hey @WenliangCao, thank you very much for addressing the initial review, you've done a very good job. There a few more minor things to resolve, I'd appreciate if you could look into it. Once it's done, we're good to merge your code. > > > > > > Hi Grigorii, thank you very much for taking the time to review my code and for your helpful guidance. I have addressed the remaining comments and pushed the updates. I hope everything looks good now, and please let me know if any further adjustments are needed. > > Thank you for addressing these. Currently, the code style check is failing, please run `dev/format-changed.sh` from the root of the project to fix. Hi Grigorii @gaturchenko , after checking the details of the Java Format Check, I found that it used base SHA 759d5b6925 from August 4. The files reported as incorrectly formatted were therefore introduced by later changes on main, rather than by my PR. I tried synchronizing my branch with the current main tip, 9dccbc3e60 from August 8, and reran dev/format-changed.sh locally. The local format check now passes, and I hope the cloud CI will pass this time as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
