Baunsgaard commented on code in PR #2553: URL: https://github.com/apache/systemds/pull/2553#discussion_r4026652399
########## src/test/java/org/apache/sysds/test/component/matrix/BenchmarkMatMult.java: ########## @@ -0,0 +1,83 @@ +package org.apache.sysds.test.component.matrix; + +import java.util.concurrent.TimeUnit; +import org.apache.sysds.runtime.matrix.data.LibMatrixMult; +import org.apache.sysds.runtime.matrix.data.MatrixBlock; +import org.apache.sysds.test.TestUtils; +import org.openjdk.jmh.annotations.*; +import org.openjdk.jmh.infra.Blackhole; +import org.openjdk.jmh.results.format.ResultFormatType; +import org.openjdk.jmh.runner.Runner; +import org.openjdk.jmh.runner.RunnerException; +import org.openjdk.jmh.runner.options.Options; +import org.openjdk.jmh.runner.options.OptionsBuilder; + +@State(Scope.Thread) +@BenchmarkMode(Mode.AverageTime) +@OutputTimeUnit(TimeUnit.MICROSECONDS) +@Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS) +@Measurement(iterations = 10, time = 1, timeUnit = TimeUnit.SECONDS) +@Fork(1) Review Comment: I would not add this JMH dependency to make a benchmark for the matrix multiply. Instead please move this from being in test to being in performance. https://github.com/apache/systemds/tree/main/src/test/java/org/apache/sysds/performance and do not add the dependency package for the benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
