niketanpansare commented on issue #855: [SYSTEMML-2520] Add documentation 
search with Algolia service
URL: https://github.com/apache/systemml/pull/855#issuecomment-474450568
 
 
   Thanks @j143-bot ... This is pretty awesome :)
   
   - [x] Chrome + Mac
   - [x] Firefox + Mac
   - [x] Safari + Mac
   - [ ] Safari + iPhone: Navigation bar is working, but the search 
functionality is disabled. Please see the attached image.
   
   
![image](https://user-images.githubusercontent.com/11686380/54622354-b1942700-4a26-11e9-87c7-0b76de59a6e4.png)
   
   Since the search functionality is very useful, I will give this PR LGTM 👍 
... But, let's wait for comments from @bertholdreinwald 
   
   @j143-bot Do you mind creating two separate JIRAs?
   
   1. Fix search bar on Safari + iPhone (low priority).
   2. Document the process of getting/maintaining the docsearch apiKey.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to