mboehm7 commented on a change in pull request #881: spark wip for review URL: https://github.com/apache/systemml/pull/881#discussion_r407233029
########## File path: scripts/staging/slicing/sparked/sparked_utils.py ########## @@ -0,0 +1,122 @@ +from pyspark.sql.functions import udf +from pyspark.sql.types import FloatType + +from slicing.base.SparkedNode import SparkedNode +from slicing.base.slicer import opt_fun, union + +calc_loss = udf(lambda target, prediction, type: calc_loss_fun(target, prediction, type), FloatType()) +model_type_init = udf(lambda type: init_model_type(type)) + + +def calc_loss_fun(target, prediction, type): + if type == 0: + return (prediction - target) ** 2 + elif type == 1: + if target == prediction: + return float(1) + else: + return float(0) Review comment: we could replace these 4 lines with return `return float(target == prediction)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
