mboehm7 commented on a change in pull request #881: spark wip for review URL: https://github.com/apache/systemml/pull/881#discussion_r407230983
########## File path: scripts/staging/slicing/sparked/sparked_slicer.py ########## @@ -0,0 +1,88 @@ +from pyspark import SparkContext + +from slicing.base.SparkedNode import SparkedNode +from slicing.base.slicer import union, opt_fun +from slicing.base.top_k import Topk +from slicing.sparked import sparked_utils +from slicing.sparked.sparked_utils import update_top_k + + +def join_enum_fun(node_a, list_b, predictions, f_l2, debug, alpha, w, loss_type, cur_lvl, top_k): + x_size = len(predictions) + nodes = [] + for node_i in range(len(list_b)): + flag = sparked_utils.slice_join_nonsense(node_i, node_a, cur_lvl) Review comment: In general, 'sparked' sounds a bit odd - maybe just replace all appearances with 'spark' ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
