kev-inn commented on a change in pull request #893:
URL: https://github.com/apache/systemml/pull/893#discussion_r416604138
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/caching/FrameObject.java
##########
@@ -155,15 +182,46 @@ public long getNumColumns() {
return dc.getCols();
}
+ private FrameBlock readFederated() {
+ FrameBlock result = new FrameBlock(_schema);
+ // provide long support?
Review comment:
`readFederated` is a kind of temporary way of working with federated
frames and still provide most of the functionality already implemented for
frames. This requires the size to be int size. In the future we probably want
to prohibit getting the whole frame from the federated workers anyway so I am
not sure if we should spare much effort on this, or even do a TODO.
Please let me know your thoughts considering those aspects, I would opt for
TODO if you believe that to be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
