Baunsgaard commented on a change in pull request #916: URL: https://github.com/apache/systemml/pull/916#discussion_r429074721
########## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinToOneHotTest.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sysds.test.functions.builtin; + +import org.apache.sysds.common.Types; +import org.apache.sysds.lops.LopProperties; +import org.apache.sysds.runtime.matrix.data.MatrixValue; +import org.apache.sysds.test.AutomatedTestBase; +import org.apache.sysds.test.TestConfiguration; +import org.apache.sysds.test.TestUtils; +import org.junit.Test; + +import java.util.Arrays; +import java.util.Comparator; +import java.util.HashMap; + +import static org.junit.Assert.fail; + +public class BuiltinToOneHotTest extends AutomatedTestBase { + private final static String TEST_NAME = "to_one_hot"; + private final static String TEST_DIR = "functions/builtin/"; + private static final String TEST_CLASS_DIR = TEST_DIR + BuiltinToOneHotTest.class.getSimpleName() + "/"; + + private final static double eps = 0; + private final static int rows = 10; + private final static int cols = 1; + private final static int numClasses = 10; + + @Override + public void setUp() { + addTestConfiguration(TEST_NAME,new TestConfiguration(TEST_CLASS_DIR, TEST_NAME, new String[]{"B"})); + } + + @Test + public void runSimpleTest() { + runToOneHotTest(false, false, LopProperties.ExecType.CP, false); + } + + @Test + public void runFailingSimpleTest() { + runToOneHotTest(false, false, LopProperties.ExecType.CP, true); + } + + private void runToOneHotTest(boolean scalar, boolean sparse, + LopProperties.ExecType instType, boolean shouldFail) { + Types.ExecMode platformOld = setExecMode(instType); + + try + { + loadTestConfiguration(getTestConfiguration(TEST_NAME)); + + //generate actual dataset + double[][] doubles = getRandomMatrix(rows, cols, 1, numClasses, 1, 7); + + // round them + double[][] A = new double[rows][cols]; + for(int i = 0; i < rows; i++) { + for(int j = 0; j < cols; j++) { + A[i][j] = Math.round(doubles[i][j]); + } + } + + int max = -1; + + for(int i = 0; i < rows; i++) { + if(A[i][0] > max) { + max = (int) A[i][0]; + } + } + + // script fails if numClasses provided is smaller than maximum value in A + int numClassesPassed = shouldFail ? max - 1 : max; + + String HOME = SCRIPT_DIR + TEST_DIR; + fullDMLScriptName = HOME + TEST_NAME + ".dml"; + programArgs = new String[]{"-explain", "-args", input("A"), String.format("%d", numClassesPassed), + output("B") }; + + + writeInputMatrixWithMTD("A", A, false); + + runTest(true, false, null, -1); Review comment: Update, I have looked into options so that if we call the system it does not require us to either check stdOut, or look if a file has been created. Unfortunately neither is available at the moment, so we will have to make some. A current idea is that the exception thrown from a stop should not be caught and just print, but be thrown all the way out to a user, but with the twist that it should still provide the same print as before if executed normally not a stack trace. Since it is another feature, I suggest not to include it in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
