Hi, With regards to #1, we have an existing JIRA for this https://issues.apache.org/jira/browse/SYSTEMML-134 . I'll update this one.
A few other things I've noticed: 1) docs/README.txt in standalone distributions (and the other *.tar.gz and *.zip) have references to BIGINSIGHTS_HOME. This is same file as docs/Language Reference/README.txt. 2) No DISCLAIMER in standalone tar.gz and zip. I believe this is a 'should' and not a 'must'. 3) In the directory of packages, the .asc files have .asc.asc files. 4) Since we have a -sources.jar, we might want to add a -javadoc.jar since maven easily automates it. Deron On Wed, Jan 20, 2016 at 1:36 PM, Mike Dusenberry <[email protected]> wrote: > Upon further review, I've found multiple issues with the "standalone" > package that should block this release candidate. > > > > > 1. The "readme.txt" in the "standalone" distribution refers to a > "jSystemML.jar" file that will be generated for the user to allow the use > of "java -jar jSystemML.jar". However, we do not package a single jar, and > instead provide a "lib" folder with all dependency jars and a base SystemML > jar named "system-ml-0.9.0-incubating.jar". Thus, a longer Java invocation > using the lib classpath is needed, or the provided > "runStandaloneSystemML.sh" script is needed, with the later being the only > obvious route for the user. This leads us to item 2. > > 2. The provided "runStandaloneSystemML.sh" is unusable due to containing > only Windows-style carriage returns, rather than the correct Unix newline > characters. Thus, the script has to be edited to remove the former > Windows-style characters and replace them with the later Unix styled ones > before the script will run. This will affect any Unix derivative, such as > Linux and OS X. Additionally, the inclusion of Windows-styled carriage > returns in our codebase is a huge concern, aside from Windows-specific > files such as ".bat" or ".exe" files. I'll open a separate thread to > discuss this, but I believe we can fix it with the addition of a Git config > setting in the project that forces Unix-style newlines upon checkin, and > still allows for OS-specific characters on local machines. > > > > > Overall, the "standalone" package is broken in this release candidate, so > we should fix that. In general, we need to clean up the execution paths of > SystemML anyway, but for now I say we quickly fix this issue, and then work > on a real solution (such as the single "SystemML.jar" for all execution > types/modes that was discussed on one of the recent PRs) for the next > release. > > > > > > - Mike > > > > > -- > > > > Michael W. Dusenberry > LinkedIn: linkedin.com/in/mikedusenberry > > > GitHub: github.com/dusenberrymw > > On Wed, Jan 20, 2016 at 10:44 AM, Niketan Pansare <[email protected]> > wrote: > > > +1 > > Niketan Pansare > > IBM Almaden Research Center > > E-mail: npansar At us.ibm.com > > http://researcher.watson.ibm.com/researcher/view.php?person=us-npansar > > From: [email protected] > > To: [email protected] > > Date: 01/20/2016 05:30 AM > > Subject: Re: [VOTE] Release SystemML 0.9-incubating (RC1) > > +1 > > -- > > Mike Dusenberry > > GitHub: github.com/dusenberrymw > > LinkedIn: linkedin.com/in/mikedusenberry > > Sent from my iPhone. > >> On Jan 20, 2016, at 3:39 AM, Frederick R Reiss <[email protected]> > > wrote: > >> > >> > >> +1 > >> > >> Sent from my iPhone > >> > >>>> On Jan 20, 2016, at 11:06 AM, Shirish Tatikonda > >>> <[email protected]> wrote: > >>> > >>> +1 > >>> > >>> > >>> > >>> On Tue, Jan 19, 2016 at 9:46 PM, Luciano Resende <[email protected] > > > >>> wrote: > >>> > >>>> Please vote on releasing the following candidate as Apache SystemML > >> version > >>>> 0.9.0! > >>>> > >>>> The vote is open for at least 72 hours and will close on Saturday, > >> January > >>>> 23 and passes if a majority of at least 3 +1 PMC votes are cast. > >>>> > >>>> [ ] +1 Release this package as Apache SystemML 0.9.0 > >>>> [ ] -1 Do not release this package because ... > >>>> > >>>> To learn more about Apache SystemML, please see > >>>> http://systemml.apache.org/ > >>>> > >>>> The tag to be voted on is v0.9.0-rc1 > >>>> (3e7e5cf6ca697ec247a7dc4e005a7f7b1cb18856) > >> > > > https://github.com/apache/incubator-systemml/tree/3e7e5cf6ca697ec247a7dc4e005a7f7b1cb18856 > >> > >>>> > >>>> The release files, including signatures, digests, etc. can be found > at: > >> > > > https://repository.apache.org/content/repositories/orgapachesystemml-1001/ > >>>> > >>>> > >>>> ===================================== > >>>> == Apache Incubator release policy == > >>>> ===================================== > >>>> Please find below the guide to release management during incubation: > >>>> http://incubator.apache.org/guides/releasemanagement.html > >>>> > >>>> ======================================= > >>>> == How can I help test this release? == > >>>> ======================================= > >>>> If you are a SystemML user, you can help us test this release by > taking > >> an > >>>> existing Algorithm or workload and running on this release candidate, > >> then > >>>> reporting any regressions. > >>>> > >>>> ================================================ > >>>> == What justifies a -1 vote for this release? == > >>>> ================================================ > >>>> -1 votes should only occur for significant stop-ship bugs or legal > >> related > >>>> issues (e.g. wrong license, missing header files, etc). Minor bugs or > >>>> regressions should not block this release. > >>>> > >>>> -- > >>>> Luciano Resende > >>>> http://people.apache.org/~lresende > >>>> http://twitter.com/lresende1975 > >>>> http://lresende.blogspot.com/ >
