+1 for fixing Protocol Buffer's version 2.4.1
On Tue, Mar 19, 2013 at 2:07 PM, Henry Saputra <[email protected]>wrote: > Hi All, > > With Tajo JIRA still pending infra work I would like to ask for quick code > review to update Tajo building guide: > > diff --git a/BUILDING.txt b/BUILDING.txt > index 37e1976..d72f9cf 100644 > --- a/BUILDING.txt > +++ b/BUILDING.txt > @@ -6,7 +6,7 @@ Requirements: > * Unix System > * JDK 1.7 > * Maven 3.0 > -* ProtocolBuffer 2.4.1+ > +* Protocol Buffers 2.4.1 > * Internet connection for first build (to fetch all Maven and Tajo > dependencies) > > > > ---------------------------------------------------------------------------------- > diff --git a/tajo-project/src/site/apt/build.apt > b/tajo-project/src/site/apt/build.apt > index 6b1a4ce..d9b4289 100644 > --- a/tajo-project/src/site/apt/build.apt > +++ b/tajo-project/src/site/apt/build.apt > @@ -11,7 +11,7 @@ Build Requirements > > * Java 1.6 or higher > > - * Protocol Buffers 2.4.1 or higher > + * Protocol Buffers 2.4.1 > > * Maven 3.0 or higher > > > > ---------------------------------------------------------------------------------- > > With this change the required Protocol Buffers is 2.4.1 instead of min of > 2.4.1. > > Seems like with Protocol Buffers 2.5.0 the generated code did not compile > because some classes inheritance got changed. > I have not look into it much but I think updating the guide to use 2.4.1 > for now should be the best way to start with Apache Tajo. > > > Thanks, > > Henry >
