[jira] [Commented] (TAJO-41) Storage handler name "row" in storage-default.xml must be "rowfile".

[Hyunsik Choi (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637162#comment-13637162
 ] 

Hyunsik Choi commented on TAJO-41:
----------------------------------

Thank you for reporting. Some default configs in storage-default.xml are wrong.

The current configs are follows:
{code:java|title=storage-default.xml (current)}
  <property>
    <name>tajo.storage.scanner-handler.row.class</name>
    <value>tajo.storage.RowFile$RowFileScanner</value>
  </property>

  <property>
    <name>tajo.storage.appender-handler.row.class</name>
    <value>tajo.storage.RowFile$RowFileAppender</value>
  </property>
{code}

The above configs must be fixed as follows:
{code:java|title=storage-default.xml (fixed)}
  <property>
    <name>tajo.storage.scanner-handler.rowfile.class</name>
    <value>tajo.storage.RowFile$RowFileScanner</value>
  </property>

  <property>
    <name>tajo.storage.appender-handler.rowfile.class</name>
    <value>tajo.storage.RowFile$RowFileAppender</value>
  </property>
{code}

This is an easy work. Is there any volunteer?

If you want to know how it works, please read 
StorageManager::getScanner(Configuration,TableMeta,Fragment,Schema) method.
                
> Storage handler name "row" in storage-default.xml must be "rowfile".
> --------------------------------------------------------------------
>
>                 Key: TAJO-41
>                 URL: https://issues.apache.org/jira/browse/TAJO-41
>             Project: Tajo
>          Issue Type: Bug
>          Components: storage
>            Reporter: Hyoseok Ryu
>
> The correct storage handler name for RowFile is 'rowfile'. However,  'row' is 
> described in storage-default.xml. It's wrong default configuration and causes 
> the following error:
> {noformat}
> 2013-04-20 17:08:08,549 ERROR master.QueryUnitAttempt 
> (QueryUnitAttempt.java:transition(307)) - FROM ryuCom >> 
> java.lang.NullPointerException
>       at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:909)
>       at tajo.storage.StorageManager.getScanner(StorageManager.java:138)
>       at tajo.engine.planner.physical.SeqScanExec.init(SeqScanExec.java:66)
>       at 
> tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:47)
>       at 
> tajo.engine.planner.physical.StoreTableExec.init(StoreTableExec.java:58)
>       at tajo.worker.Task.run(Task.java:376)
>       at tajo.worker.TaskRunner$1.run(TaskRunner.java:272)
>       at java.lang.Thread.run(Thread.java:679)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira