[ 
https://issues.apache.org/jira/browse/TAJO-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726656#comment-13726656
 ] 

camelia c commented on TAJO-96:
-------------------------------

Hello,

I looked into the code You uploaded in the review board and , as You asked if I 
have any suggestions, in my humble opinion we could write several classes 
implementing the rewrite engine interface, e.g. one for the outer join 
transformation, another for selection pushdown and so on.
This would be particularly useful for the rewriting algorithm used in outer 
join transformation.
Furthermore, the rewriting is carried out in stages, so we cannot put all rules 
in the same collection and apply all eligible ones one one node at the same 
time.

Thank You!

Yours sincerely,
Camelia




                
> Design and implement rewrite rule interface and the rewrite rule engine.
> ------------------------------------------------------------------------
>
>                 Key: TAJO-96
>                 URL: https://issues.apache.org/jira/browse/TAJO-96
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>              Labels: rewrite
>             Fix For: 0.2-incubating
>
>
> So far, some rewrite rules are embedded in LogicalOptimizer and 
> LogicalPlanner. In order to encourage contributors to implement more useful 
> rewrite rules, we need well-designed rewrite rule interface and the rewrite 
> rule engine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to