[ 
https://issues.apache.org/jira/browse/TAJO-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752255#comment-13752255
 ] 

Hyunsik Choi commented on TAJO-59:
----------------------------------

+1

The patch looks great. There is one proposal. I'm not sure whether 'smallint' 
is enough for the length domain in DBStore, or not. Why don't we increase the 
domain of length to integer (-2^31 ~ 2^31)?
                
> Implement Char Datum Type
> -------------------------
>
>                 Key: TAJO-59
>                 URL: https://issues.apache.org/jira/browse/TAJO-59
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: catalog
>            Reporter: Hyunsik Choi
>            Assignee: Jihoon Son
>             Fix For: 0.2-incubating
>
>         Attachments: TAJO-59.patch
>
>
> CharDatum represents fixed-length strings.
> This issue involves the following tasks
> * Refactoring CharDatum to represent fixed-length strings
> * Improving LogicalPlanner to support the type length
> * Improving DBStore to support the type length
> * Adding createChar(String val, int length) to DatumFactory
> * Modifying CSVFile, RowFile, RawFile, RCFile, and Trevni to support 
> fixed-length strings

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to