[ 
https://issues.apache.org/jira/browse/TAJO-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773684#comment-13773684
 ] 

Hudson commented on TAJO-186:
-----------------------------

SUCCESS: Integrated in Tajo-trunk-postcommit #461 (See 
[https://builds.apache.org/job/Tajo-trunk-postcommit/461/])
TAJO-186: Improve column resolving method. (hyunsik) (hyunsik: 
https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=bd1619de0c0a371363382540f70bd876c08ea765)
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
* CHANGES.txt
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlan.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/FromTable.java
* 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/TargetListManager.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
* 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ScanNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/JoinClause.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/json/FromTableDeserializer.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalPlannerUtils.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/SchemaUtil.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalPlanner.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/IndexScanNode.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java

                
> Improve column resolving method
> -------------------------------
>
>                 Key: TAJO-186
>                 URL: https://issues.apache.org/jira/browse/TAJO-186
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.2-incubating
>
>         Attachments: TAJO-186_2.patch, TAJO-186.patch
>
>
> The current column resolving method (LogicalPlanner::createFieldEval) usually 
> finds columns from relations in the current query block. If not found, it 
> tries to find columns from other query blocks.
> However, this way cannot resolve some cases. Please take a look at the below 
> example:
> {noformat}
> select col1 as rank from table1 order by rank
> {noformat}
> In the above case, the column 'rank' cannot be found in any relation. So, in 
> this case, we currently use LogicalPlan::findColumnFromChildNode method to 
> resolve columns from a child node.
> But, this way cannot resolve a column 'total' in the below cases:
> {noformat}
> select ..., sum(col1) as total ... having total > 1
> {noformat}
> Resolving columns should also consider the current node's output schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to