[
https://issues.apache.org/jira/browse/TAJO-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817955#comment-13817955
]
Jihoon Son commented on TAJO-289:
---------------------------------
Thanks for your patch.
There are some points that need to discuss.
* What is the purpose of JobConf? If you want to store key-value pairs, we have
already TajoConf for the same purpose. In addition, it looks that JobConf is
not used in your patch.
* Why did you divide the issue about HCatalogStore into separate sub-issues
like 'HCatalogStore supports SELECT statement' and 'HCatalogStore supports DROP
TABLE statement'? I think that HCatalogStore does not work until all the
sub-issues are submitted.
* It would be better that codes for checking null values move to some other
class instead of DatumFactory. We may need to design a new class to handle null
values from hive stores.
> HCatalogStore supports SELECT statement
> ---------------------------------------
>
> Key: TAJO-289
> URL: https://issues.apache.org/jira/browse/TAJO-289
> Project: Tajo
> Issue Type: Sub-task
> Components: catalog
> Affects Versions: 0.8-incubating
> Reporter: JaeHwa Jung
> Assignee: JaeHwa Jung
> Fix For: 0.8-incubating
>
> Attachments: TAJO-289.patch
>
>
> I designed Tajo to use Hive metastore with HCatalog.
> In this case, Tajo has to have an interface to connect to HCatalog.
> And I think that this connect is very useful to connect to another catalogs
> as follows:
> some different Hive catalogs, HBase catalogs
> So, I named this interface as CatalogDriver. It will has some properties as
> follows:
> - catalog namespace name
> - catalog URI
> - catalog driver class
--
This message was sent by Atlassian JIRA
(v6.1#6144)
