[ 
https://issues.apache.org/jira/browse/TAJO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825010#comment-13825010
 ] 

Hyunsik Choi commented on TAJO-176:
-----------------------------------

Great job!

In overall, the patch looks great for me. The extensive unit tests are also 
nice.

But, there are a few of things to be improved.

* java.sql.DatabaseMetaData and java.sql.Driver have additional methods in JDK 
7. So, the current patch cannot be compiled and work in java 7. It can be 
solved by overriding java.sql.DatabaseMetaData and java.sql.Driver of JDK7 
without @Override annotation.
* There are many unused imports. You can find them in TajoDriver, 
TajoResultSetMetaData, TajoResultSetBase, TestTajoJdbc, and TajoResultSet 
classes.

> Implement Tajo JDBC Driver
> --------------------------
>
>                 Key: TAJO-176
>                 URL: https://issues.apache.org/jira/browse/TAJO-176
>             Project: Tajo
>          Issue Type: New Feature
>          Components: client
>            Reporter: Hyunsik Choi
>            Assignee: Keuntae Park
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-176.patch
>
>
> Tajo is required to be integrated with legacy BI or OLAP tools. For this, 
> Tajo should provide a JDBC driver.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to