[ 
https://issues.apache.org/jira/browse/TAJO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825109#comment-13825109
 ] 

Keuntae Park edited comment on TAJO-176 at 11/18/13 4:45 AM:
-------------------------------------------------------------

Thank you for the kind review, Jihoon and Hyunsik

I've uploaded new patch for the comments:

1.  Same way to handle the unimplemented functions
  - Not supported functions throw exception
  - All methods that report supporting capabilities of database functions in 
DatabaseMetaData return true or false

2. Correcting wrong exception method
  - Exception specifies the name of the method not supported

3. Pool close
  - Concurrent execution of multiple TajoClients does not matter, because 
TajoClient does not release the connection to the pool but just closes it
  ** Please, check the test cases in testMultipleConnections and 
testMultipleConnectionsSequentialClose of TestTajoJdbc 

4. Supporting jdk7
  - Implement all the additional methods in jdk7 and replace "@Override 
annotation" with "//JDK1.7" comment

5. Unused imports
  - Remove all

6. rebase


was (Author: sirpkt):
Thank you for the kind review, Jihoon and Hyunsik

I've uploaded new patch for the comments:

1.  Same way to handle the unimplemented functions
  - Not supported functions throw exception
  - All methods that report supporting capabilities of database functions in 
DatabaseMetaData return true or false

2. Correcting wrong exception method
  - Exception specifies the name of the method not supported

3. Pool close
  - Concurrent execution of multiple TajoClients does not matter, because 
TajoClient does not release the connection to the pool but just closes it
  -- Please, check the test cases in testMultipleConnections and 
testMultipleConnectionsSequentialClose of TestTajoJdbc 

4. Supporting jdk7
  - Implement all the additional methods in jdk7 and replace "@Override 
annotation" to "//JDK1.7"

5. Unused imports
  - Remove all

6. rebase

> Implement Tajo JDBC Driver
> --------------------------
>
>                 Key: TAJO-176
>                 URL: https://issues.apache.org/jira/browse/TAJO-176
>             Project: Tajo
>          Issue Type: New Feature
>          Components: client
>            Reporter: Hyunsik Choi
>            Assignee: Keuntae Park
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-176.patch, TAJO-176_2.patch
>
>
> Tajo is required to be integrated with legacy BI or OLAP tools. For this, 
> Tajo should provide a JDBC driver.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to