[
https://issues.apache.org/jira/browse/TAJO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833463#comment-13833463
]
Min Zhou edited comment on TAJO-305 at 11/27/13 5:05 AM:
---------------------------------------------------------
OMG.. Only recently did I realize the way I tried to kill a Query is quite
different from yours. I added a killQuery rpc call in
TajoMasterClientProtocol.proto thus client can remotely request master stop the
query. Tajomaster will forward the request to QueryMaster and then QueryMaster
receives a kill event to drive the state machine of query /
subquery/task/taskattempt and finially recycle all the resource this query
lanuches.
You added a rpc call in QueryMasterClientProtocol.proto and more than half of
logic for killing a query had done. TajoClient hold a mapping from queryId to
its QueryMaster. Just need to retrieve a QueryMaster from queryId, and call
that rpc method.
My bad, sorry.
was (Author: coderplay):
OMG.. On recently did I realize the way I tried to kill a Query is quite
different from yours. I added a killQuery rpc call in
TajoMasterClientProtocol.proto thus client can remotely request master stop the
query. Tajomaster will forward the request to QueryMaster and then QueryMaster
receives a kill event to drive the state machine of query /
subquery/task/taskattempt and finially recycle all the resource this query
lanuches.
You added a rpc call in QueryMasterClientProtocol.proto and more than half of
logic for killing a query had done. TajoClient hold a mapping from queryId to
its QueryMaster. Just need to retrieve a QueryMaster from queryId, and call
that rpc method.
My bad, sorry.
> Implement killQuery feature
> ---------------------------
>
> Key: TAJO-305
> URL: https://issues.apache.org/jira/browse/TAJO-305
> Project: Tajo
> Issue Type: Improvement
> Components: master
> Reporter: Hyunsik Choi
> Assignee: Min Zhou
> Fix For: 0.8-incubating
>
>
> In the current version, killQuery feature is partially implemented. We need
> to complete this feature and add a command to tsql.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
