[ 
https://issues.apache.org/jira/browse/TAJO-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838990#comment-13838990
 ] 

Jihoon Son commented on TAJO-316:
---------------------------------

This work looks great as a prototype of the join order optimization for the 
distributed join.

This patch contains some changes of global planning of other operators such as 
sort as well as the join ordering.
Are these changes just a refactoring of the global planner?
I think that it would be better that the refactoring is proceeded in a new 
issue, but it looks hard to be separated.

Other parts of the patch looks good to me.
Here is my +1.
Please remove unused imports from some tests before you commit.

> Improve GreedyHeuristicJoinOrderAlgorithm to deal with non-commutative joins
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-316
>                 URL: https://issues.apache.org/jira/browse/TAJO-316
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>              Labels: cbo
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-316.patch, TAJO-316_2.patch
>
>
> GreedyHeuristicJoinOrderAlgorithm is a default cost-based join order 
> algorithm. It is designed only for inner joins, and it cannot deal with 
> non-commutative joins, such as left/right/full outer join and semi/anti join. 
> The main goal of this issue is to improve this algorithm to deal with them.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to