[
https://issues.apache.org/jira/browse/TAJO-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843927#comment-13843927
]
Hyunsik Choi commented on TAJO-336:
-----------------------------------
+1
Nice work. In overall, the patch looks great for me.
In addition, I would like to give some suggestions. tajo-hcatalog.pom file
contains various ambiguous hadoop version profiles as follows:
{code:title=tajo-hcatalog.pom}
<id>hadoop20</id>
...
<id>hadoop25</id>
...
<id>hadoop26</id>
{code}
Actually, the profile names are mismatch to actual hadoop versions. If
hadoop-2.0.5's profile id is hadoop25, what will be profile id for
hadoop-2.5.0? I think that full version name has more readability. In addition,
in pom.xml, hadoop20 indicates 1.1.2. It should be fixed.
{code}
<hadoop20.version>1.1.2</hadoop20.version>
{code}
Besides, hadoop version profile should be placed on tajo-project/pom.xml
instead of tajo-hcatalog, and Tajo should follow the specified hadoop version.
Then, it would be better that tajo-hcatalog follows hadoop version that tajo
uses.
> Separate catalog stores into separate modules
> ---------------------------------------------
>
> Key: TAJO-336
> URL: https://issues.apache.org/jira/browse/TAJO-336
> Project: Tajo
> Issue Type: Improvement
> Components: build, catalog
> Affects Versions: 0.8-incubating
> Reporter: Hyunsik Choi
> Assignee: JaeHwa Jung
> Priority: Blocker
> Fix For: 0.8-incubating
>
> Attachments: TAJO-336.patch, TAJO-336_2.patch
>
>
> Catalog stores, such as HCatalogStore, involves dependencies to other
> systems. Their dependencies may be conflict from Tajo's dependencies because
> the dependent library versions can be varied in many cases.
> As to this problem, separating catalog stores from catalog-server module
> would be a good solution.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
