[ 
https://issues.apache.org/jira/browse/TAJO-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849382#comment-13849382
 ] 

Hyunsik Choi commented on TAJO-424:
-----------------------------------

+1

Nice work. In addition, I would like to two suggestions. (1) 
SerializeDeserialize is verb, and I think it is only verb in many member 
variables. How about changing the name to SerializeDeserialize*r*. (2) In 
addition, if we support custom (de) serializer, CSVFile is not a proper name 
anymore. We need to rename the format name and its properties, such 
csvfile.delimiter and csvfile.serde. Probably, it is right time to rename them 
because Tajo is under the relatively early stage. It would be good to create a 
separate jira issue for it.

Anyway, I agreed this patch.

> Make serializer/deserializer configurable in CSVFile
> ----------------------------------------------------
>
>                 Key: TAJO-424
>                 URL: https://issues.apache.org/jira/browse/TAJO-424
>             Project: Tajo
>          Issue Type: Improvement
>          Components: storage
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>         Attachments: TAJO-424.patch
>
>
> The CSVFile serializer/deserializer is fixed to TextSerializeDeserialize in 
> the LazyTuple. This should be configurable.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to