[ 
https://issues.apache.org/jira/browse/TAJO-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858862#comment-13858862
 ] 

Hudson commented on TAJO-458:
-----------------------------

SUCCESS: Integrated in Tajo-trunk-postcommit #652 (See 
[https://builds.apache.org/job/Tajo-trunk-postcommit/652/])
TAJO-458: Visit methods of LogicalPlanVisitor should take a query block as 
parameter. (hyunsik) (hyunsik: 
https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=c7990c724898cd136fe87d508a4b07f62ede3567)
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
* CHANGES.txt
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExplainLogicalPlanVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java


> Visit methods of LogicalPlanVisitor should take a query block as parameter
> --------------------------------------------------------------------------
>
>                 Key: TAJO-458
>                 URL: https://issues.apache.org/jira/browse/TAJO-458
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-458.patch
>
>
> A logical plan is composed of multiple query blocks. Each logical node must 
> belong to one query block. A query block instance  provides lots of 
> information. So, it is essential information in many rewrite rules and 
> optimizer implementations. 
> However, so far, individual rewrite rule or optimizer implementation have 
> dealt with query block directly. It may be error-prone and cause duplicated 
> codes. This patch refactors each visitor method of LogicalPlanVisitor to take 
> a query block as a parameter.  
> I'm expecting that this change will provide more convenience for rewrite 
> rules and optimization development.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to