++1. I love this suggestion. Henry, the pull request mechanism is also useful, but developers should maintain the commit logs in their branches. I think that it will be another burden for developers.
Thanks. 2014/1/2 Henry Saputra <[email protected]> > Hi Hyunsik, another alternative is to use ASF Github mirror repo pull > request mechanism to do the review and do manual merge by committers. > > Other podlings such as Apache Spark has been doing it and so far it > helps with reviews. > > - Henry > > On Wed, Jan 1, 2014 at 11:12 PM, Hyunsik Choi <[email protected]> wrote: > > Hi folks, > > > > As the community and the number of contributors grow, more patches are > > being submitted. We have faced the increasing burden of patch peer > > review. So far, we have mostly submitted patches to Jira and leaved > > comments on the corresponding JIRA issue. This way is not bad, but its > > productivity for review is not good. > > > > In order to mitigate the burden of patch review, I propose that we > > should use reviewboard for more significant than minor issues. > > Reviewboard allows reviewers to directly add ideas and comments on the > > diff or source code. In addition, Reviewboard enables reviews to view > > the only difference between two patches. I think that they are really > > nice features. I believe we will experience more efficient and > > convenient review process if we use reviewboard more. I also think > > that this rule should be strongly recommended rather than mandatory. > > > > If you have any idea, feel free to suggest me. Also, I welcome just an > > agreement expression about this idea. > > > > - hyunsik > -- Jihoon Son Database & Information Systems Group, Prof. Yon Dohn Chung Lab. Dept. of Computer Science & Engineering, Korea University 1, 5-ga, Anam-dong, Seongbuk-gu, Seoul, 136-713, Republic of Korea Tel : +82-2-3290-3580 E-mail : [email protected]
