[
https://issues.apache.org/jira/browse/TAJO-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872140#comment-13872140
]
Tajo QA commented on TAJO-478:
------------------------------
{color:red}*-1 overall.*{color:red} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12623147/TAJO-478_20140115_23%3A31%3A17.patch
against master revision 69700bf.
{color:green}+1 @author. The patch does not contain any @author
tags.{color:green}
{color:red}-1 tests included. The patch doesn't appear to include any new
or modified tests.{color:red}
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac. The applied patch does not increase the total
number of javac compiler warnings.{color:green}
{color:green}+1 javadoc. The applied patch does not increase the total
number of javadoc warnings.{color:green}
{color:green}+1 checkstyle. The patch generated 0 code style
errors.{color:green}
{color:green}+1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.{color:green}
{color:green}+1 release audit. The applied patch does not increase the
total number of release audit warnings.{color:green}
{color:green}+1 core tests. The patch passed unit tests in .{color:green}
Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/43//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/43//console
This message is automatically generated.
> Add request-patch-review.py that helps submitting patches to jira and
> reviewboard.
> ----------------------------------------------------------------------------------
>
> Key: TAJO-478
> URL: https://issues.apache.org/jira/browse/TAJO-478
> Project: Tajo
> Issue Type: Improvement
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.8-incubating
>
> Attachments: TAJO-478.patch, TAJO-478_20140105_02:22:58.patch,
> TAJO-478_20140105_02:25:29.patch, TAJO-478_20140109_15:44:43.patch,
> TAJO-478_20140115_18:48:36.patch, TAJO-478_20140115_19:01:21.patch,
> TAJO-478_20140115_23:31:17.patch
>
>
> As we discussed the recent review process, review requests to reviewboard are
> strongly recommended in Tajo project.
> http://markmail.org/message/rszy3knctczko23d#query:+page:1+mid:qnozgapggzmwxqrw+state:results
> This patch adds a helper utility to allow users to create a patch against a
> specified branch, submit the patch to a specified Jira, and create a review
> request in reviewboard.
> This utility is borrowed from Apache Kafka.
> https://github.com/apache/kafka/blob/trunk/kafka-patch-review.py
> But, I modified some options and add several new features, and this patch
> includes its documentation.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
