[ 
https://issues.apache.org/jira/browse/TAJO-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878419#comment-13878419
 ] 

Hudson commented on TAJO-543:
-----------------------------

SUCCESS: Integrated in Tajo-master-build #26 (See 
[https://builds.apache.org/job/Tajo-master-build/26/])
TAJO-543: InsertNode and CreateTableNode should play their roles. (hyunsik: 
https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=d06dd852e5f299a9cb329f870e4795a7bfda1917)
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/PersistentStoreNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ShuffleFileWriteNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/UnaryNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ColumnPartitionedTableStoreExec.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
* CHANGES.txt
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/InsertNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/StoreTableNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/StoreIndexNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/CreateTableNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/PartitionedTableScanNode.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java


> InsertNode and CreateTableNode should play their roles
> ------------------------------------------------------
>
>                 Key: TAJO-543
>                 URL: https://issues.apache.org/jira/browse/TAJO-543
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-543.patch
>
>
> Currently, CreateTableNode and InsertNode are just intermediate 
> representations. They are rewritten to StoreTableNode. But, StoreTableNode 
> does not contain some necessary fields, such as output table, target table, 
> target columns, overwrite flag and create table flag. So far, these fields 
> are kept in QueryContext.
> This implementation causes unnecessary and complex rewrite of 
> DistributedQueryHookManager. As a result, it is hard to maintain and manage 
> CREATE/INSERT plans.
> The main objective of this issue is to improve LogicalPlanner to use 
> CreateTableNode and InsertNode throughout the planning phase and eliminate 
> complex rewrite in DistributedQueryHookManager.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to