Ideally, I'd like for us to point out the issues before just fixing them. This will help make sure everyone understands the rules around Apache.
If we see code that is not in compliance, it would be better to: - Identify the compliance issue on the dev mailing alias and explain why its an issue. - Ask the person who introduced to fix it. - Wait an appropriate amount of time. - (if not fixed) Raise a JIRA asking for the fix assigned to the person who introduced. - (if still not fixed) Someone else fix it. There are a few files I'm curious about, for example Mark where did you find PathBasedPropertySourceProvider? On Sat, Jan 3, 2015 at 3:27 PM, Mark Struberg <[email protected]> wrote: > This is really straight forward. Apache doesn't copy code from other > projects where we don't have all the full rights. And for those sources we > clearly do not own the copyright! > > > How do you know that those sources are IP clean? You simply cannot be sure > because you didn't write it yourself. > > This would have required a formal donation to the ASF an own IP check > (going through all the history, etc) and of course mentioning in the NOTICE > files. > > > And there is a second important point: this code is just not needed! It's > from the spring-ant integration it seems. What do we need that for? It is > totally simple to write this ourselves EXACTLY as we need it. There is just > no need for 20 additional classes which we barely can use. > > Btw we also need to review all the LICENSE and NOTICE files. > > LieGrue, > strub > > > > > > On Saturday, 3 January 2015, 21:17, Anatole Tresch <[email protected]> > wrote: > > >Hi Mark > > > > > >once more: I would expect to ask/discuss things first before just > removing: > > > > > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/formats/ConfigurationFormat.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/formats/PropertiesFormat.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/formats/PropertiesXmlFormat.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/logging/AbstractDelegatingLogger.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/logging/Log4j2Logger.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/logging/Log4jLogger.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/logging/Slf4jLogger.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/AbstractFileResolvingResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/AntPathMatcher.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/ClassPathResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/DefaultResourceLoader.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/FileSystemResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/InputStreamResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/PathMatchingDefaultResourceLoader.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/PathMatchingResourcePatternResolver.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/ReflectionUtils.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/ResourceUtils.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/UrlResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/VfsResource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/internal/resource/VfsUtils.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/PathBasedPropertySourceProvider.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/ResourcePropertySourceProvider.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/resources/InputStreamSource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/resources/Resource.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/resources/ResourceLoader.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/util/ClassUtils.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/main/java/org/apache/tamaya/core/util/StringUtils.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/test/java/org/apache/tamaya/core/testdata/TestPropertyDefaultSourceProvider.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/test/java/org/apache/tamaya/core/testdata/TestPropertySourceProvider.java > > * > file://C:/Users/Anatole/IdeaProjects/incubator-tamaya/core/src/test/resources/META-INF/services/org.apache.tamaya.spi.PropertySourceProvider > >-> Parts of it may be rewritten, OK. Fair enough. > >-> Actually I dont understand, why we cannot reuse some of the code here: > it is Apache licencsed as well. We just have to mention it. > >-> Basically only 8 artifacts (more or less) would be afftected, by far > not all. > > > > > >I am really thinking of stopping my work here. Mark., I aüpreciate > discussing things, but simply throwing away things within in minutes is not > a collaboration model I will support. It is not worth my time! > > > > > >Cheers, > >Anatole > > > > > > > > > > > > > > > > > >2015-01-03 18:45 GMT+01:00 Mark Struberg <[email protected]>: > > > >Just check what is NOT Copyright Apache but something else. Sadly this is > actually quite a lot. > >> > >>LieGrue, > >>strub > >> > >> > >> > >> > >> > >>On Saturday, 3 January 2015, 18:33, John D. Ament <[email protected]> > wrote: > >> > >> > >>> > >>> > >>>I'll be curious to see this when pushed. > >>> > >>> > >>>On Sat Jan 03 2015 at 12:18:10 PM Mark Struberg <[email protected]> > wrote: > >>> > >>>Hi! > >>>> > >>>>I now removed the logging parts: it is not our job to integrate with > various logger frameworks. This should be done by the container/program who > uses us as dependency. > >>>> > >>>>I also removed quite a few classes which are taken from the spring > framework. They are copyrighted to the original authors and we don't have > all rights for it! Those classes are trivial anyway and it would be simple > to put code from commons or write it ourselves. > >>>> > >>>> > >>>>LieGrue, > >>>>strub > >>>> > >>> > >>> > >> > > > > > > > >-- > > > >Anatole Tresch > >Java Engineer & Architect, JSR Spec Lead > >Glärnischweg 10 > >CH - 8620 Wetzikon > > > > > >Switzerland, Europe Zurich, GMT+1 > >Twitter: @atsticks > >Blogs: http://javaremarkables.blogspot.ch/ > >Google: atsticks > >Mobile +41-76 344 62 79 > > > > >
