Basically comparing an object of type A with an instance of type B without any inheritance relationship beyond Object makes no sense. The question is what the String is representing: a value or the key and what the code there is supposed to do. A fact is that equals will (and should) always return false.
J Anatole 2016-08-31 20:28 GMT+02:00 P. Ottlinger <[email protected]>: > Hi! > > When I tried to find out why the build broke I stumbled upon the > findbugs warnings, the high priority one looks like a bug to me: a > string is compared to a PropertyValue .... do we need to call > getProperty(String) first before comparing? > > <snip> > PropertySourceChangeBuilder.java:102, EC_UNRELATED_TYPES, Priority: High > > Call to org.apache.tamaya.spi.PropertyValue.equals(String) in > org.apache.tamaya.events.PropertySourceChangeBuilder. > compare(PropertySource, > PropertySource) > > This method calls equals(Object) on two references of different class > types and analysis suggests they will be to objects of different classes > at runtime. Further, examination of the equals methods that would be > invoked suggest that either this call will always return false, or else > the equals method is not be symmetric (which is a property required by > the contract for equals in class Object). > </snip> > > Please adapt the buildnumber to the latest one: > > https://builds.apache.org/job/Tamaya-Master-branch/708/ > findbugsResult/HIGH/ > > Phil > -- *Anatole Tresch* PPMC Member Apache Tamaya JCP Star Spec Lead *Switzerland, Europe Zurich, GMT+1* *maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> * *Twitter: @atsticks, @tamayaconf*
